Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delivery format: add and provision format field to EgressConfig in contract #3970

Open
Cali0707 opened this issue Jul 4, 2024 · 4 comments · May be fixed by #3987
Open

Delivery format: add and provision format field to EgressConfig in contract #3970

Cali0707 opened this issue Jul 4, 2024 · 4 comments · May be fixed by #3987
Assignees
@Cali0707
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Cali0707
Copy link
Member

Cali0707 commented Jul 4, 2024

Problem
To support dispatching events in the format specified in the format field being added into the delivery spec of components, we need to add a field into the contract, and then provision that field from the control plane.

Persona:
Which persona is this feature for?

Exit Criteria
Unit tests indicating that the reconciler is setting the contract properly

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1-2

Additional context (optional)
Add any other context about the feature request here.
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 4, 2024

/help

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 4, 2024

@Cali0707:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 4, 2024
This was referenced Jul 4, 2024
Open
Merged
@Cali0707
Copy link
Member Author

/assign

@Cali0707 Cali0707 linked a pull request Jul 12, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cali0707 Cali0707

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provision delivery format in contract Cali0707/eventing-kafka-broker
1 participant
@Cali0707