Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to latest Quarkus 3.8.x and matching vertx #3929

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Jun 12, 2024

Fixes #

Proposed Changes

  • 🧹 Update to latest Quarkus 3.8 and matching vertx

Release Note


Docs

@knative-prow knative-prow bot added area/data-plane size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2024
Copy link

knative-prow bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.20%. Comparing base (9c96bce) to head (7a34e4f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3929      +/-   ##
==========================================
- Coverage   48.22%   48.20%   -0.02%     
==========================================
  Files         246      246              
  Lines       14533    14533              
==========================================
- Hits         7008     7006       -2     
- Misses       6820     6821       +1     
- Partials      705      706       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Copy link
Contributor Author

matzew commented Jun 12, 2024

/retest

1 similar comment
@matzew
Copy link
Contributor Author

matzew commented Jun 19, 2024

/retest

@matzew matzew force-pushed the bump_quarkus_3.8.5_upstream/main branch 2 times, most recently from 3b8957b to c9ad915 Compare July 8, 2024 11:43
@matzew
Copy link
Contributor Author

matzew commented Jul 8, 2024

/retest

4 similar comments
@matzew
Copy link
Contributor Author

matzew commented Jul 8, 2024

/retest

@matzew
Copy link
Contributor Author

matzew commented Jul 8, 2024

/retest

@matzew
Copy link
Contributor Author

matzew commented Jul 8, 2024

/retest

@matzew
Copy link
Contributor Author

matzew commented Jul 8, 2024

/retest

@matzew matzew force-pushed the bump_quarkus_3.8.5_upstream/main branch from c9ad915 to a1f899f Compare July 9, 2024 08:22
@matzew
Copy link
Contributor Author

matzew commented Jul 9, 2024

/retest-required

4 similar comments
@matzew
Copy link
Contributor Author

matzew commented Jul 9, 2024

/retest-required

@matzew
Copy link
Contributor Author

matzew commented Jul 9, 2024

/retest-required

@matzew
Copy link
Contributor Author

matzew commented Jul 9, 2024

/retest-required

@matzew
Copy link
Contributor Author

matzew commented Jul 10, 2024

/retest-required

@matzew matzew force-pushed the bump_quarkus_3.8.5_upstream/main branch from a1f899f to cb9dc2c Compare July 11, 2024 08:35
@matzew
Copy link
Contributor Author

matzew commented Jul 11, 2024

/retest

@matzew matzew force-pushed the bump_quarkus_3.8.5_upstream/main branch from cb9dc2c to 7a34e4f Compare July 25, 2024 09:06
Copy link

knative-prow bot commented Jul 25, 2024

@matzew: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_eventing-kafka-broker_main 7a34e4f link true /test unit-tests
upgrade-tests_eventing-kafka-broker_main 7a34e4f link true /test upgrade-tests
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main 7a34e4f link true /test channel-reconciler-tests-sasl-ssl
channel-reconciler-tests-ssl_eventing-kafka-broker_main 7a34e4f link true /test channel-reconciler-tests-ssl
channel-reconciler-tests-sasl-plain_eventing-kafka-broker_main 7a34e4f link true /test channel-reconciler-tests-sasl-plain
channel-integration-tests-ssl_eventing-kafka-broker_main 7a34e4f link true /test channel-integration-tests-ssl
reconciler-tests-namespaced-broker_eventing-kafka-broker_main 7a34e4f link true /test reconciler-tests-namespaced-broker
reconciler-tests_eventing-kafka-broker_main 7a34e4f link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -43,7 +43,7 @@
<spotless.plugin.version>2.38.0</spotless.plugin.version>

<!-- dependencies version -->
<vertx.version>4.4.7</vertx.version>
<vertx.version>4.5.7</vertx.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierDipi when I change this back to 4.4.7, the "trancing" unit test failure goes away.

However, the one inside Quarkus is based on 4.5.7

Looks like our vertx dependency is a bit unbalanced scope? I was thinking we work with that version from inside the Quarkus

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, that is just opentelemetry (and junit5):

mvn dependency:tree | grep 4.4.7
[INFO] +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] +- io.vertx:vertx-junit5:jar:4.4.7:test
[INFO] |  +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] +- io.vertx:vertx-junit5:jar:4.4.7:test
[INFO] |  +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] +- io.vertx:vertx-junit5:jar:4.4.7:test
[INFO] |  +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] +- io.vertx:vertx-junit5:jar:4.4.7:test
[INFO] |  |  +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] +- io.vertx:vertx-junit5:jar:4.4.7:test
[INFO]    |  +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] |  +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] +- io.vertx:vertx-junit5:jar:4.4.7:test

@matzew
Copy link
Contributor Author

matzew commented Jul 25, 2024

Getting tracing unit test failure:

java.lang.AssertionError: 
Expected size: 3 but was: 2 in:
[SpanData{spanContext=ImmutableSpanContext{traceId=3d0c6e0c2589b9ee991f55fe663a0580, spanId=4df2574965f51733, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=true}, parentSpanContext=ImmutableSpanContext{traceId=3d0c6e0c2589b9ee991f55fe663a0580, spanId=7c8aa44997b44aee, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=true, valid=true}, resource=Resource{schemaUrl=null, attributes={service.name="unknown_service:java", telemetry.sdk.language="java", telemetry.sdk.name="opentelemetry", telemetry.sdk.version="1.32.0"}}, instrumentationScopeInfo=InstrumentationScopeInfo{name=io.vertx, version=null, schemaUrl=null, attributes={}}, name=POST, kind=SERVER, startEpochNanos=1721904841534002141, endEpochNanos=1721904841556133337, attributes=AttributesMap{data={http.url=http://localhost:8083/broker-ns/broker-name, messaging.message_id=1234, messaging.message_source=/hello, http.scheme=http, http.method=POST, http.response.status_code=202, messaging.message_type=type, url.path=/broker-ns/broker-name, http.status_code=202, http.request.method=POST}, capacity=128, totalAddedValues=10}, totalAttributeCount=10, events=[], totalRecordedEvents=0, links=[], totalRecordedLinks=0, status=ImmutableStatusData{statusCode=UNSET, description=}, hasEnded=true},
    SpanData{spanContext=ImmutableSpanContext{traceId=3d0c6e0c2589b9ee991f55fe663a0580, spanId=7c8aa44997b44aee, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=true}, parentSpanContext=ImmutableSpanContext{traceId=00000000000000000000000000000000, spanId=0000000000000000, traceFlags=00, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=false}, resource=Resource{schemaUrl=null, attributes={service.name="unknown_service:java", telemetry.sdk.language="java", telemetry.sdk.name="opentelemetry", telemetry.sdk.version="1.32.0"}}, instrumentationScopeInfo=InstrumentationScopeInfo{name=io.vertx, version=null, schemaUrl=null, attributes={}}, name=POST, kind=CLIENT, startEpochNanos=1721904841488911753, endEpochNanos=1721904841561891761, attributes=AttributesMap{data={http.url=http://localhost:8083/broker-ns/broker-name, http.method=POST, url.full=http://localhost:8083/broker-ns/broker-name, http.response.status_code=202, http.status_code=202, http.request.method=POST}, capacity=128, totalAddedValues=6}, totalAttributeCount=6, events=[], totalRecordedEvents=0, links=[], totalRecordedLinks=0, status=ImmutableStatusData{statusCode=UNSET, description=}, hasEnded=true}]

	at dev.knative.eventing.kafka.broker.receiver.impl.ReceiverVerticleTracingTest.traceIsPropagated(ReceiverVerticleTracingTest.java:190)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant