Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused editor config Java plugin #4122

Merged

Conversation

pierDipi
Copy link
Member

We use spotless to reformat Java code and editor config is not used anymore.

We use spotless to reformat Java code and editor config is not used
anymore.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/data-plane labels Sep 30, 2024
@knative-prow knative-prow bot requested review from aliok and creydr September 30, 2024 15:40
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.47%. Comparing base (e3ede63) to head (a8e80d5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4122   +/-   ##
=======================================
  Coverage   48.47%   48.47%           
=======================================
  Files         244      244           
  Lines       14888    14888           
=======================================
  Hits         7217     7217           
  Misses       6943     6943           
  Partials      728      728           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

pierDipi commented Oct 1, 2024

/cc @creydr @matzew

@knative-prow knative-prow bot requested a review from matzew October 1, 2024 06:11
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

knative-prow bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@knative-prow knative-prow bot merged commit 55b6264 into knative-extensions:main Oct 1, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants