Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.15] Support explicit protocol configuration in KafkaChannel secret #4131

Open
wants to merge 3 commits into
base: release-1.15
Choose a base branch
from
Open

[release-1.15] Support explicit protocol configuration in KafkaChannel secret #4131

wants to merge 3 commits into from

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #4126

Support explicit protocol configuration in KafkaChannel secret so that the same format as Kafka Broker secrets can be used for KafkaChannel authentication configuration.

@pierDipi @knative-prow-robot
Support explicit protocol configuration in KafkaChannel secret
41e1851 
KafkaChannel has historically used the "legacy" secret format,
however, it has limitations as not having the explitic protocol
configuration, we're left with guessing the protocol.

We will continue supporting the "legacy" format, however,
we will encourage users to use the new secret format, so that
it can also be used for Kafka Broker, KafkaChannel and KafkaSink.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi @knative-prow-robot
Remove unnecessary saslType in non-legacy test user secrets
545d549 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi @knative-prow-robot
Use sasl.mechanism in KafkaSource tests
57c81e5 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow-robot knative-prow-robot mentioned this pull request Oct 10, 2024
Merged
@knative-prow knative-prow bot requested review from aliok and Leo6Leo October 10, 2024 12:12
@knative-prow knative-prow bot added area/test size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 48.11%. Comparing base (d1e6cb4) to head (57c81e5).

Files with missing lines Patch % Lines
control-plane/pkg/reconciler/consumer/consumer.go 0.00% 9 Missing ⚠️
control-plane/pkg/reconciler/channel/channel.go 0.00% 7 Missing and 1 partial ⚠️
...security/secrets_provider_legacy_channel_secret.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.15    #4131      +/-   ##
================================================
- Coverage         48.14%   48.11%   -0.04%     
================================================
  Files               246      246              
  Lines             14663    14673      +10     
================================================
  Hits               7060     7060              
- Misses             6879     6888       +9     
- Partials            724      725       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member

/retest-required

pierDipi
pierDipi approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest-required

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@pierDipi pierDipi mentioned this pull request Oct 10, 2024
Closed
@pierDipi
Copy link
Member

/retest

@pierDipi
Copy link
Member

/test reconciler-tests-namespaced-broker

@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 14, 2024

@knative-prow-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests-namespaced-broker_eventing-kafka-broker_release-1.15 57c81e5 link true /test reconciler-tests-namespaced-broker

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@aliok aliok Awaiting requested review from aliok

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knative-prow-robot @pierDipi