Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPv6 listener config option #1300

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add IPv6 listener config option #1300

wants to merge 1 commit into from

Conversation

covert8
Copy link

@covert8 covert8 commented Oct 18, 2024 •
edited
Loading

Changes

Adds config option to enable listening on IPv6 (default false)

  • 🐛 Enable listening on IPv6

/kind bug

Fixes #1299

Release Note

Add ability to change address family used for kourier listeners (default IPv4 value unchanged)

Docs

pending

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 18, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 18, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: covert8 / name: Louis R (c3e7de2)

@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: covert8
Once this PR has been reviewed and has the lgtm label, please assign retocode for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 18, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 18, 2024

Welcome @covert8! It looks like this is your first PR to knative-extensions/net-kourier 🎉

@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 18, 2024

Hi @covert8. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2024
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode Awaiting requested review from ReToCode

@skonto skonto Awaiting requested review from skonto

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for IPV6 listeners
1 participant
@covert8