Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Kourier gateway CPU limit #1157

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Increase Kourier gateway CPU limit #1157

merged 1 commit into from
Nov 14, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Nov 14, 2023

Increases the CPU limits of kourier gateway instead of controller to avoid readliness probe failure ~500 KSVCs.

Release Note

The CPU limit of kourier Gateway limit is now increased to avoid CPU limitation issues in larger installations.

/cc @ReToCode @skonto

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2023
@nak3 nak3 changed the title Increase Kourier gateway CPU limit instead of controller Increase Kourier gateway CPU limit Nov 14, 2023
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2023
Copy link

knative-prow bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad58d90) 80.81% compared to head (bf38497) 80.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1157   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files          18       18           
  Lines        1392     1392           
=======================================
  Hits         1125     1125           
  Misses        213      213           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit 1a0457f into knative-extensions:main Nov 14, 2023
42 checks passed
openshift-merge-bot bot pushed a commit to openshift-knative/net-kourier that referenced this pull request Nov 14, 2023
…d of controller (#119)

* Increase Kourier Gateway CPU limit instead of controller (knative-extensions#1157)

* Update artifact
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/net-kourier that referenced this pull request Nov 14, 2023
openshift-merge-bot bot pushed a commit to openshift-knative/net-kourier that referenced this pull request Nov 14, 2023
…d of controller (#120)

* Increase Kourier Gateway CPU limit instead of controller (knative-extensions#1157)

* Update artifact

---------

Co-authored-by: Kenjiro Nakayama <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants