Revert "Add loopclosure linter" #7083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6a0495c.
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/XS
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7083 +/- ##
=======================================
Coverage 78.31% 78.31%
=======================================
Files 250 250
Lines 13291 13291
=======================================
Hits 10409 10409
Misses 2351 2351
Partials 531 531 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
g1rjeevan
pushed a commit
to g1rjeevan/eventing
that referenced
this pull request
Jul 20, 2023
Reverts knative#7079 It causes ``` Running [/home/runner/golangci-lint-1.52.0-linux-amd64/golangci-lint run --out-format=github-actions --new-from-patch=/tmp/tmp-1767-brlK8gkkRq5N/pull.patch --new=false --new-from-rev= --go=1.20] in [] ... level=error msg="Running error: unknown linters: 'loopclosure', run 'golangci-lint help linters' to see the list of supported linters" ``` Maybe the version we use in CI doesn't support this linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7079
It causes
Maybe the version we use in CI doesn't support this linter