Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Integration sink and source: all together #8254

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

matzew
Copy link
Member

@matzew matzew commented Oct 14, 2024

In progress (contains bits from closed #8239 ) and is layered on-top of #8238

/hold

…lly the container source for the handling of the kamelet workloads. the logic for applying the env-vars is a bit verbose, but can be improved.

Tests/lifeccyle and some other improvements are still missing. but this works.

Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Oct 14, 2024
Copy link

knative-prow bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 16.01942% with 519 lines in your changes missing coverage. Please review.

Project coverage is 64.92%. Comparing base (aa6f73b) to head (4f516d8).

Files with missing lines Patch % Lines
...iler/integration/sink/resources/container_image.go 0.00% 101 Missing ⚠️
pkg/reconciler/integration/sink/integrationsink.go 0.00% 98 Missing ⚠️
...er/integration/source/resources/containersource.go 0.00% 69 Missing ⚠️
pkg/reconciler/integration/helper.go 0.00% 59 Missing ⚠️
pkg/reconciler/integration/source/controller.go 0.00% 43 Missing ⚠️
pkg/reconciler/integration/sink/controller.go 0.00% 36 Missing ⚠️
...reconciler/integration/source/integrationsource.go 0.00% 30 Missing ⚠️
.../apis/sinks/v1alpha1/integration_sink_lifecycle.go 15.38% 22 Missing ⚠️
pkg/apis/sources/v1alpha1/integration_lifecycle.go 57.57% 14 Missing ⚠️
pkg/apis/sources/v1alpha1/register.go 0.00% 11 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8254      +/-   ##
==========================================
- Coverage   66.57%   64.92%   -1.66%     
==========================================
  Files         371      392      +21     
  Lines       18282    18900     +618     
==========================================
+ Hits        12172    12271      +99     
- Misses       5321     5835     +514     
- Partials      789      794       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

knative-prow bot commented Oct 14, 2024

@matzew: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing_main 4f516d8 link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant