make defmt attributes forward input attributes #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is sugar for `#[export_name = "$item_name"]
Lotterleben
approved these changes
Dec 15, 2020
macros/src/lib.rs
Outdated
| @@ -95,8 +121,13 @@ pub fn panic_handler(args: TokenStream, input: TokenStream) -> TokenStream { | |||
| .into(); | |||
| } | |||
|
|
|||
| let attrs = &f.attrs; | |||
| if let Err(e) = reject_attributes("panic_handler", attrs, &["export_name", "no_mangle"]) { | |||
There was a problem hiding this comment.
imo possible attribute clashes should be documented in https://defmt.ferrous-systems.com/panic.html?highlight=panic_han#defmtpanic_handler
macros/src/lib.rs
Outdated
| }; | ||
|
|
||
| fn reject_attributes( |
There was a problem hiding this comment.
could you add a short description of what this function does?
(nit: the function name is a bit misleading, I would've found something like check_attribute_conflict more helpful but that's really splitting hairs.)
|
bors r+ |
|
bors r- |
|
Canceled. |
|
bors r=Lotterleben |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work towards fixing #252
#[export_name]OR#[no_mangle])(I was expecting
#[timestamp] #[inline(always)] fn foo() -> u64 { 0 }to fail at link time but it works ... perhaps export_name undoes inlining?)