Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use statements in defmt-test #294

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Conversation

Sh3Rm4n
Copy link
Contributor

@Sh3Rm4n Sh3Rm4n commented Dec 1, 2020

Closes #289

Thanks to @japaric's detailed instructions this was straight forward to implement.

The only thing missing right now, is to update the error message, as "only function items are allowed" is no longer true.

#[warn(clippy::match_like_matches_macro)]
#[warn(clippy::chars_next_cmp)]
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think that with an updated error message this would be good to go.

firmware/defmt-test/macros/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defmt-test: Allow use in test module
3 participants