add defmt-logger and defmt-print #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defmt-logger is probe-run's code that formats defmt frames into a log::Logger sink defmt-print is a command-line tool that decodes defmt and prints it to the console
|
This seems good! bors r+ |
|
Build succeeded: |
bors bot
added a commit
to knurling-rs/probe-run
that referenced
this pull request
Jan 12, 2021
132: use defmt-logger r=jonas-schievink a=japaric follow up of knurling-rs/defmt#338 Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defmt-logger is probe-run's code that formats defmt frames into a log::Log-ger sink
defmt-print is a command-line tool that decodes defmt and prints it to the console
TODO
defmt-print --versionshould print supported defmt versionother thoughts: qemu-run should maybe use defmt-logger instead of its own thing?