Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup defmt tags #351

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Cleanup defmt tags #351

merged 1 commit into from
Jan 20, 2021

Conversation

jonas-schievink
Copy link
Contributor

This adds a write tag to identify format strings from user-defined write! invocations, and splits up the fmt tag into prim for primitives, and derived for #[derive(Format)]-generated strings. This allows tools to distinguish user-controlled format strings from generated ones.

japaric
japaric approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@japaric
Copy link
Member

japaric commented Jan 20, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 20, 2021

Build succeeded:

@bors bors bot merged commit 574f77f into main Jan 20, 2021
@bors bors bot deleted the cleanup-defmt-tags branch January 20, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japaric japaric japaric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonas-schievink @japaric