Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify docs on Write::write #355

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Clarify docs on Write::write #355

merged 1 commit into from
Jan 21, 2021

Conversation

jonas-schievink
Copy link
Contributor

Fixes #168

japaric
japaric approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@japaric
Copy link
Member

japaric commented Jan 21, 2021

bors r+

bors bot added a commit that referenced this pull request Jan 21, 2021
@bors @jonas-schievink
Merge #354 #355
a05a0c0 
354: f64 support r=japaric a=jonas-schievink

Closes #346

355: Clarify docs on `Write::write` r=japaric a=jonas-schievink

Fixes #168

Co-authored-by: Jonas Schievink <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 21, 2021

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Jan 21, 2021

Build succeeded:

@bors bors bot merged commit e67e6f6 into knurling-rs:main Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japaric japaric japaric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarifying the docs on Write::write
2 participants
@jonas-schievink @japaric