Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

348 format for duration #391

Merged
merged 2 commits into from
Feb 16, 2021
Merged

348 format for duration #391

merged 2 commits into from
Feb 16, 2021

Conversation

Urhengulas
Copy link
Member

This implements the trait defmt::Format for core::time::Duration and also adapts defmt_macros::write! to achieve this.

Fixes #348

@Urhengulas Urhengulas self-assigned this Feb 15, 2021
jonas-schievink
jonas-schievink reviewed Feb 16, 2021
View reviewed changes
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 16, 2021

Build succeeded:

@bors bors bot merged commit 42be5f6 into main Feb 16, 2021
@bors bors bot deleted the 348-format-for-duration branch February 16, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink left review comments

Assignees

@Urhengulas Urhengulas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement Format for core::time::Duration
2 participants
@Urhengulas @jonas-schievink