Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Format for the core::{iter, ops, slice} structs. #472

Merged
merged 3 commits into from
May 15, 2021
Merged

Implement Format for the core::{iter, ops, slice} structs. #472

merged 3 commits into from
May 15, 2021

Conversation

derekdreery
Copy link
Contributor

No description provided.

@Urhengulas
Copy link
Member

Is it on purpose that RangeTo is omitted?

@derekdreery
Copy link
Contributor Author

Is it on purpose that RangeTo is omitted?

Oops! Added now :)

Urhengulas
Urhengulas approved these changes May 15, 2021
View reviewed changes
Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

bors r+

@bors
Copy link
Contributor

bors bot commented May 15, 2021

Build succeeded:

@bors bors bot merged commit f6270ae into knurling-rs:main May 15, 2021
@Urhengulas
Copy link
Member

I will add snapshot tests in a separate PR

@Urhengulas Urhengulas changed the title Implement Format for the core::ops structs. Implement Format for the core::{iter, ops, slice} structs. May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urhengulas Urhengulas Urhengulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekdreery @Urhengulas