Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4/n] test: do not depend on custom InternalFormatter #524

Merged
merged 1 commit into from
Jun 30, 2021
Merged

[4/n] test: do not depend on custom InternalFormatter #524

merged 1 commit into from
Jun 30, 2021

Conversation

Dirbaio
Copy link
Contributor

@Dirbaio Dirbaio commented Jun 30, 2021 •
edited
Loading

Part of #492

#508 removes InternalFormatter, so it will no longer be possible to store a Vec<u8> there for fake-writing the bytes for testing. This PR replaces that with writing a thread-local Vec<u8>.

@Dirbaio Dirbaio mentioned this pull request Jun 30, 2021
Merged
@Dirbaio Dirbaio force-pushed the test-no-internalformatter branch 2 times, most recently from 6791aed to 97ace89 Compare June 30, 2021 01:50
@Dirbaio Dirbaio mentioned this pull request Jun 30, 2021
Closed
bors bot added a commit that referenced this pull request Jun 30, 2021
@bors @Dirbaio
Merge #508
5abfc33 
508: [5/n] Format trait v2 r=japaric a=Dirbaio

Part of #492 . Depends on ~~#505 #507 #521~~ #524

- Implemented new Format trait according to #492.
- Adjusted everything else accordingly.

Co-authored-by: Dario Nieuwenhuis <[email protected]>
@bors bors bot merged commit 7a7f665 into knurling-rs:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@japaric japaric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dirbaio @japaric