Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the defmt-macros crate #531

Merged
merged 34 commits into from
Jul 16, 2021
Merged

refactor the defmt-macros crate #531

merged 34 commits into from
Jul 16, 2021

Conversation

japaric
Copy link
Member

@japaric japaric commented Jul 15, 2021

NOT READY FOR REVIEW. I just wanted to signal that I'm working on this

@japaric
Copy link
Member Author

japaric commented Jul 16, 2021

(done with the refactor but now this needs a rebase. will rebase later and mark the PR as 'ready for review')

@japaric japaric marked this pull request as ready for review July 16, 2021 14:24
macros/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, r=me with added newline

Co-authored-by: Jonas Schievink <[email protected]>
@japaric
Copy link
Member Author

japaric commented Jul 16, 2021

bors r+

@bors bors bot merged commit cfb71f2 into main Jul 16, 2021
@bors
Copy link
Contributor

bors bot commented Jul 16, 2021

Build succeeded:

@bors bors bot deleted the refactor-macros branch July 16, 2021 14:53
@Urhengulas Urhengulas changed the title refactor the macros crate refactor the defmt::macros crate Jul 16, 2021
@Urhengulas Urhengulas changed the title refactor the defmt::macros crate refactor the defmt-macros crate Jul 16, 2021
@Dirbaio Dirbaio mentioned this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants