Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused cortex-m-rt in panic-probe #561

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Conversation

Dirbaio
Copy link
Contributor

@Dirbaio Dirbaio commented Aug 18, 2021

It's nice to not depend on a particular cortex-m-rt version, it'll help the 0.6 -> 0.7 breaking transition.

This shouldn't be a breaking change. Could we get a release of this as 0.2.1 to help with the transition? Thank you!

It's nice to not depend on a particular cortex-m-rt version, it'll help the 0.6 -> 0.7 breaking transition.

This shouldn't be a breaking change. Could we get a release of this as 0.2.1 to help with the transition? Thank you!
@jonas-schievink
Copy link
Contributor

bors r+

@Urhengulas
Copy link
Member

Could we get a release of this as 0.2.1 to help with the transition?

Although we said we want to avoid another 0.2.x release, I think we can do this, if it is beneficial. And maybe it is obvious, but how does it help with the transition? 😁

@Dirbaio
Copy link
Contributor Author

Dirbaio commented Aug 19, 2021

how does it help with the transition?

You can't have two versions of cortex-m-rt in the crate tree at the same time, they conflict because they need to set globally-unique things like the linker script and interrupt vectors.

panic-probe pulling in cortex-m-rt 0.6 completely prevents users from using cortex-m-rt 0.7

@jonas-schievink
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 19, 2021

Build succeeded:

@bors bors bot merged commit 3b4af2f into knurling-rs:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants