Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #628 #633

Merged
merged 8 commits into from
Nov 25, 2021
Merged

fix #628 #633

merged 8 commits into from
Nov 25, 2021

Conversation

spookyvision
Copy link
Contributor

@spookyvision spookyvision commented Nov 25, 2021 •
edited
Loading

open questions:

also make this honor the env var?

// print/src/main.rs:28
const READ_BUFFER_SIZE: usize = 1024;

(answered: no, irrelevant)

add some hints in the app template?
(answered: yes)

@jonas-schievink
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 25, 2021

Build succeeded:

@bors bors bot merged commit 964c8e7 into main Nov 25, 2021
@bors bors bot deleted the 628-rtt-buffer-size branch November 25, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink left review comments

@jonathanpallant jonathanpallant jonathanpallant left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spookyvision @jonas-schievink @jonathanpallant