defmt: add impl for core::net #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Urhengulas
requested changes
Mar 6, 2023
defmt/src/impls/core_/net.rs
Outdated
Comment on lines
30
to
48
| impl Format for net::Ipv6Addr { | ||
| fn format(&self, fmt: Formatter) { | ||
| crate::write!( | ||
| fmt, | ||
| "{:x}:{:x}:{:x}:{:x}:{:x}:{:x}:{:x}:{:x}", | ||
| self.octets()[0], | ||
| self.octets()[1], | ||
| self.octets()[2], | ||
| self.octets()[3], | ||
| self.octets()[4], | ||
| self.octets()[5], | ||
| self.octets()[6], | ||
| self.octets()[7] | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Ipv6Addr::octets(&self) returns a [u8; 16] (docs). Are you purposefully just using the first eight?
There was a problem hiding this comment.
Whoops, that's a mistake on my part, good catch, thanks!
defmt/src/impls/core_/net.rs
Outdated
Comment on lines
13
to
20
| crate::write!( | ||
| fmt, | ||
| "{}.{}.{}.{}", | ||
| self.octets()[0], | ||
| self.octets()[1], | ||
| self.octets()[2], | ||
| self.octets()[3] | ||
| ); |
There was a problem hiding this comment.
You could also do the following. You don't have to; I just find it pretty.
Suggested change
| crate::write!( | |
| fmt, | |
| "{}.{}.{}.{}", | |
| self.octets()[0], | |
| self.octets()[1], | |
| self.octets()[2], | |
| self.octets()[3] | |
| ); | |
| let [a, b, c, d] = ip.octets(); | |
| crate::write!(fmt, "{}.{}.{}.{}", a, b, c, d); |
With println! you could even do following, but unfortunately we didn't implement that (yet):
let [a, b, c, d] = ip.octets();
println!("{a}.{b}.{c}.{d}");
|
Thank you! bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Mar 13, 2023
740: Snapshot tests for `core::net` r=Urhengulas a=Urhengulas This PR adds snapshot tests for the implements added in #733. While doing that, I also clean up a bit. Co-authored-by: Urhengulas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds formatting for
core::nettypes.core::netis currently unstable, so this is feature gated.