Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds crate_name to Symbol #742

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Adds crate_name to Symbol #742

merged 5 commits into from
Mar 21, 2023

Conversation

BriocheBerlin
Copy link
Contributor

@BriocheBerlin BriocheBerlin commented Mar 16, 2023 •
edited by Urhengulas
Loading

Fixes #532.

When running e.g. $ arm-none-eabi-readelf -Ws target/thumbv7em-none-eabihf/debug/hello | rg crate_name on the my-app app-template, it returns:

$ arm-none-eabi-readelf -Ws target/thumbv7em-none-eabihf/debug/hello | rg crate_name
165: 00000002     1 OBJECT  GLOBAL DEFAULT    8 {"package":"my-app","tag":"defmt_println","data":"Hello, world!","disambiguator":"1780402918813241646","crate_name":"hello"}
171: 00000001     1 OBJECT  GLOBAL DEFAULT    8 {"package":"defmt","tag":"defmt_prim","data":"{=__internal_Display}","disambiguator":"1668500705691287208","crate_name":"defmt"}
177: 00000003     1 OBJECT  GLOBAL DEFAULT    8 {"package":"panic-probe","tag":"defmt_error","data":"{}","disambiguator":"9448177036453248414","crate_name":"panic_probe"}

@BriocheBerlin BriocheBerlin marked this pull request as ready for review March 21, 2023 11:52
@Urhengulas Urhengulas changed the title Adds crate_name to Symbol. Adds crate_name to Symbol Mar 21, 2023
Urhengulas
Urhengulas approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 21, 2023

Merge conflict.

@Urhengulas
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Mar 21, 2023

Build succeeded:

@bors bors bot merged commit c16f1b7 into main Mar 21, 2023
@bors bors bot deleted the symbol_name branch March 21, 2023 16:16
@therealfrauholle therealfrauholle mentioned this pull request Apr 4, 2023
Merged
bors bot added a commit that referenced this pull request Apr 5, 2023
@bors @therealfrauholle @Urhengulas
Merge #747
329bee6 
747: Bump wire version r=Urhengulas a=therealfrauholle

The changes introduced in #742 add the field `crate_name` to the wire format. As far as I understand this requires a bump of the defmt version.

Also, is this a reason to yank version 0.3.5? This problem caused me quite some headache today and I hope this spares others from going through the same pain.

Co-authored-by: Finn Hermeling <[email protected]>
Co-authored-by: Urhengulas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urhengulas Urhengulas Urhengulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include crate name in symbol name
2 participants
@BriocheBerlin @Urhengulas