Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defmt-macros: Upgrade to syn 2 #760

Merged
merged 2 commits into from
Jun 15, 2023
Merged

defmt-macros: Upgrade to syn 2 #760

merged 2 commits into from
Jun 15, 2023

Conversation

mkroening
Copy link
Contributor

@mkroening mkroening commented Jun 14, 2023 •
edited
Loading

This performs the upgrade to syn 2.

I did this in two steps:

  1. I upgraded to syn 2 by changing as little as possible about the code, while still passing all UI tests.
  2. I migrated get_defmt_format_option to the new parse_nested_meta method. This makes the code much more readable while keeping the same behavior.

CC: @Urhengulas, I saw you started working on this on the syn2 branch, after I already started on this.

@mkroening mkroening changed the title Upgrade to syn 2 defmt-macros: Upgrade to syn 2 Jun 14, 2023
@mkroening mkroening marked this pull request as ready for review June 14, 2023 13:53
Urhengulas
Urhengulas approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mkroening. LGTM!

@Urhengulas Urhengulas added this pull request to the merge queue Jun 15, 2023
Merged via the queue into knurling-rs:main with commit ba53b2e Jun 15, 2023
@mkroening mkroening deleted the syn2 branch June 15, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urhengulas Urhengulas Urhengulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkroening @Urhengulas