decoder: Ignore AArch64 mapping symbols #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AArch64 ELF spec includes "mapping symbols" for identifying contiguous data/code regions in a binary: https:/ARM-software/abi-aa/blob/main/aaelf64/aaelf64.rst#mapping-symbols Ignore these if we encounter them in the ".defmt" section rather than returning an error.
paulmenage
changed the title
|
Can you please share the error you encounter without the PR? |
|
I get an error like |
Urhengulas
approved these changes
Aug 30, 2023
Error was:
```
error: &-masking with zero
--> qemu/src/bin/bitflags.rs:10:1
|
10 | / bitflags! {
11 | | #[allow(clippy::bad_bit_mask)]
12 | | struct Flags: u8 {
13 | | #[cfg(not(never))]
... |
23 | | }
24 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask
= note: `#[deny(clippy::bad_bit_mask)]` on by default
= note: this error originates in the macro `__impl_bitflags` which comes from the expansion of the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info)
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AArch64 ELF spec includes "mapping symbols" for identifying contiguous data/code regions in a binary:
https:/ARM-software/abi-aa/blob/main/aaelf64/aaelf64.rst#mapping-symbols
Ignore these if we encounter them in the ".defmt" section rather than returning an error such as
Error: failed to demangle defmt symbol '$d.3': expected value at line 1 column 1