Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to set image annotations #1090

Closed
seankhliao opened this issue Jul 4, 2023 · 1 comment · Fixed by #1426
Closed

option to set image annotations #1090

seankhliao opened this issue Jul 4, 2023 · 1 comment · Fixed by #1426
Labels
lifecycle/stale

Comments

@seankhliao
Copy link
Contributor

Currently we can set image labels with --image-label, but when working with multi platform images, there's no canonical image to look at for metadata.
Registries like github's ghcr instead look at the annotations on the image/index.
I'd like a way to set those.

https://kubernetes.slack.com/archives/C01T7DTP65S/p1687637484368199
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
@eugene-eeo eugene-eeo mentioned this issue Dec 10, 2023
Closed
seankhliao added a commit to seankhliao/ko that referenced this issue Oct 15, 2024
@seankhliao
allow setting annotations
3c94bd2 
This adds a new build flag for setting annotations
on image indexes and manifests.
Annotations are no longer copied from the base image.
`org.opencontainers.image.base.digest` and
`org.opencontainers.image.base.name`
are always set to the resolved values.

Usage example:

```sh
ko build --image-annotation foo=bar,fizz=buzz .
```

Fixes ko-build#1090
Fixes ko-build#1090
Fixes ko-build#1231
Fixes ko-build#1235
Fixes ko-build#1395
@seankhliao seankhliao mentioned this issue Oct 15, 2024
Merged
imjasonh pushed a commit that referenced this issue Oct 16, 2024
@seankhliao @imjasonh
allow setting annotations
c98cb1e 
This adds a new build flag for setting annotations
on image indexes and manifests.
Annotations are no longer copied from the base image.
`org.opencontainers.image.base.digest` and
`org.opencontainers.image.base.name`
are always set to the resolved values.

Usage example:

```sh
ko build --image-annotation foo=bar,fizz=buzz .
```

Fixes #1090
Fixes #1090
Fixes #1231
Fixes #1235
Fixes #1395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow setting annotations seankhliao/ko
1 participant
@seankhliao