fix: the req data should be consumed on error #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 98.11% 98.18% +0.06%
==========================================
Files 1 1
Lines 53 55 +2
==========================================
+ Hits 52 54 +2
Misses 1 1
Continue to review full report at Codecov.
|
popomore
reviewed
Aug 18, 2018
| @@ -29,6 +30,9 @@ module.exports = function onerror(app, options) { | |||
| // to node-style callbacks. | |||
| if (err == null) return; | |||
|
|
|||
| // ignore all pedding request stream | |||
| if (this.req) sendToWormhole(this.req); | |||
There was a problem hiding this comment.
sendToWormhole 已经将 req 的异常情况都处理了。
|
LGTM |
fengmk2
force-pushed
the
make-sure-req-data-was-consumed
branch
from
76b3ce8
to
e7e012e
Compare
|
4.1.0 |
fengmk2
added a commit
to eggjs/egg-multipart
that referenced
this pull request
Aug 19, 2018
The stream will be auto consume by koa-onerror see koajs/onerror#33
fengmk2
added a commit
to eggjs/egg-multipart
that referenced
this pull request
Aug 19, 2018
The stream will be auto consume by koa-onerror see koajs/onerror#33 closes eggjs/egg#2897
4 tasks
fengmk2
added a commit
to eggjs/egg-multipart
that referenced
this pull request
Aug 20, 2018
The stream will be auto consume by koa-onerror see koajs/onerror#33 closes eggjs/egg#2897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes eggjs/egg#2897