Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar showing on fullscreen Firefox videos #170

Closed
ghost opened this issue Jul 29, 2019 · 7 comments
Closed

Status bar showing on fullscreen Firefox videos #170

ghost opened this issue Jul 29, 2019 · 7 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jul 29, 2019

As you can see, I have made this video fullscreen, and the status bar still shows.

Image

I'm certain this is not intended behavior. Furthermore, when making Firefox natively fullscreen with the green button the status bar hides. This behavior occurs on master.

@ghost
Copy link
Author

ghost commented Jul 29, 2019

Upon further investigation, this culprit appears to be 49a1494

Reverting this value back to 4 fixes the issue I am facing.

But unfortunately, when changing this value back to 4, #124 obviously resurfaces.

I'm not 100% sure if fixing both issues is possible as I don't have a good enough understanding of the codebase.

@koekeishiya
Copy link
Owner

This isn't much to do with codebase, but more with how macOS window ordering/layering work. As far as I know there is no way to fix both of these issues.

@ghost
Copy link
Author

ghost commented Jul 29, 2019

That's a real shame, I haven't had that many run-ins with #124, so I think I'll stick to having it set to 4.

@koekeishiya koekeishiya added addressed on master; not released Fixed upstream, but not yet released bug Something isn't working labels Jul 29, 2019
@koekeishiya
Copy link
Owner

I agree that this issue is more annoying/breaking than the other, reverted to 4.

@ghost
Copy link
Author

ghost commented Jul 29, 2019

Cool

@ghost ghost closed this as completed Jul 29, 2019
@dominiklohmann
Copy link
Collaborator

dominiklohmann commented Jul 29, 2019

Here's another workaround that should work without reverting the behaviour:

When a window is resized and its frame is equal to the frame of the display its on, make the window appear topmost. Undo this when the window is resized back.

@koekeishiya
Copy link
Owner

I don't think doing that is worth it. Having the statusbar not being topmost is not a be a big deal, as windows are padded by that height anyway.

@koekeishiya koekeishiya removed the addressed on master; not released Fixed upstream, but not yet released label Sep 3, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants