-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KokkosBlas: Add GEMV that wraps BLAS (and cuBLAS) #16
Comments
OK we need to fix this with respect to BLAS and CuBLAS. The seconds thing is another issue. |
So what does this need to do for Stokhos? |
@crtrott When you say "the second thing," do you mean the issue of whether
For some Stokhos Scalar types in Tpetra, |
Blocks: trilinos/Trilinos#1169
KokkosBlas::gemv currently exists, but it does not currently call the BLAS library or cuBLAS where appropriate.
There is a subtlety in whether Tpetra uses this GEMV as a matrix-vector product, or as the dot product of each column of a MultiVector with a single Vector. The difference is that matrix-vector products do all computations with Scalar values (actually
Tpetra::MultiVector::impl_scalar_type
), while the intermediate sums in a dot product have typeTpetra::MultiVector::dot_type
. The two types are usually the same, except for Scalar types that come from Stokhos. We have to decide whether we want GEMV to support both cases, or just one of them.In practice, BLAS implementations only support types for which
impl_scalar_type == dot_type
. Thus, this is really about the interface that we present to users.The text was updated successfully, but these errors were encountered: