-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kokkos - Define empty functions when profiling disabled #1424
Labels
Feature Request
Create new capability; will potentially require voting
Milestone
Comments
ndellingwood
added
the
Feature Request
Create new capability; will potentially require voting
label
Feb 19, 2018
This function signature looks wrong:
Why isn't it |
@nmhamster Good catch, the signature for the declaration in the .hpp does not match that of the impl in the .cpp. I'll fix that. |
Will get this in today (Tuesday) |
ndellingwood
added a commit
to ndellingwood/kokkos
that referenced
this issue
Feb 21, 2018
This commit to address issue kokkos#1424 Requested so user codes that include profiling hooks so user codes/packages do not need to if-guard
Closed
Have PR #1427 in, will test more extensively tomorrow with spotchecks and in Trilinos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@crtrott requested the following functions be defined when profiling is disabled so that Trilinos codes (e.g. kokkos-kernels, tpetra) do not need to #if guard when profiling is disabled:
The text was updated successfully, but these errors were encountered: