Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ETI support #3157

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Remove ETI support #3157

merged 2 commits into from
Jul 11, 2020

Conversation

masterleinad
Copy link
Contributor

@masterleinad masterleinad commented Jul 6, 2020 •
edited
Loading

Mostly reverts #1599. An alternative to #3152 as discussed there.

@masterleinad masterleinad mentioned this pull request Jul 6, 2020
Closed
@masterleinad masterleinad requested a review from crtrott July 6, 2020 16:10
dalg24
dalg24 reviewed Jul 8, 2020
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd like another pair of eyes to look over this

@crtrott crtrott added the Blocks Promotion Overview issue for release-blocking bugs label Jul 8, 2020
crtrott
crtrott approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member

@crtrott crtrott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too. What could possibly go wrong anyway when removing 50k plus lines.

@crtrott crtrott merged commit 0970579 into kokkos:develop Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 left review comments

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
Blocks Promotion Overview issue for release-blocking bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masterleinad @dalg24 @crtrott