Fix dedup of linker flags for shared libs on cmake <= 3.12 #3176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing is currently missing issues with shared library builds.
Because CMake <= 3.12 does not provide a 'target_link_options', you have to hack link options through
target_link_libraries
. These do not get effectively deduplicated. This leads to the same flag appearing multiple times on the link lines in certain cases. For the-arch=X
flag with nvcc, this causes an actual error.This only adds flags to kokkoscore avoiding the need for deduplication.