Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to optimize for CPU architecture of local machine #4930

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

masterleinad
Copy link
Contributor

IMHO there are a lot of cases where the targeted machine is the same as the one compiled on and adding a native option simplifies the choice in these cases and also allows optimizing for architectures that we don't already have a separate configuration option for.

@fnrizzi
Copy link
Contributor

fnrizzi commented Apr 4, 2022

can we make a list of pros/cons for this? And what the implications are? I don't see why this can cause weird problems.
Thse user is still responsible if he/she enables this.
I know @PhilMiller has some reservations against this, right?

Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's clear that it is user's responsibility to enable this and I don't see any drawbacks for exposing this.

@masterleinad
Copy link
Contributor Author

@masterleinad
Copy link
Contributor Author

Retest this please.

@masterleinad masterleinad added the Question For Kokkos internal and external contributors and users label Apr 7, 2022
@masterleinad masterleinad changed the title [WIP] Add option to optimize for CPU architecture of local machine Add option to optimize for CPU architecture of local machine Apr 7, 2022
@crtrott crtrott merged commit a03b0f1 into kokkos:develop Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question For Kokkos internal and external contributors and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants