Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecation warnings with OpenMPExec::validate_partition #4982

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Apr 27, 2022

Fixup for #4737
Candidate for cherry-picking into hypothetical 3.6 patch release

OpenMPExec::validate_partition was deprecated but still used in OpenMP::partition_master (which is also deprecated) which caused deprecation warnings to be emitted from the <OpenMP/Kokkos_OpenMP_Exec.hpp> header even when user code is not using the facility.
I deferred the implementation to a function that does not have the [[deprecated]] attribute.

Copy link
Contributor

@nmm0 nmm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dalg24
Copy link
Member Author

dalg24 commented Apr 27, 2022

Failures (No space left on device) is unrelated. Besides none of these builds had OpenMP enabled so merging without re-running.

@dalg24 dalg24 merged commit c272440 into kokkos:develop Apr 27, 2022
@dalg24 dalg24 deleted the fix_deprecated_warnings_with_omp branch April 27, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants