Change the default execution policy behavior of the OpenACC backend #6772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom synchronous to asynchronous executions. - Change the default OpenACC async_arg value from acc_async_sync to acc_async_noval. - Add acc_wait(async_arg) to scalar reduction operations (parallel_reduce()).
| @@ -35,15 +35,15 @@ class OpenACCInternal { | |||
|
|
|||
| public: | |||
| static int m_acc_device_num; | |||
| int m_async_arg = acc_async_sync; | |||
| int m_async_arg = acc_async_noval; | |||
There was a problem hiding this comment.
What's the difference between acc_async_noval and acc_async_sync?
There was a problem hiding this comment.
acc_async_novel means that the kernels are submitted to a default asynchronous queue, and acc_async_sync means that kernels are submitted to a default synchronous queue.
In the OpenACC execution model, all tasks submitted to the same OpenACC queue will be executed in order. |
masterleinad
approved these changes
Jan 31, 2024
crtrott
approved these changes
Feb 1, 2024
dalg24
reviewed
Feb 1, 2024
|
The OpenACC build passed |
Closed
seyonglee
added a commit
to seyonglee/kokkos
that referenced
this pull request
May 15, 2024
…am-policy) constructs in the OpenACC backend.
- This PR handles a missing case not covered by the previous PR kokkos#6772
This PR also fixes the OpenACC backend error in the thread-safety test in PR kokkos#6938.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default execution policy behavior of the OpenACC backend from synchronous to asynchronous executions.