SYCL: Make sure to call find_dependency for oneDPL if necessary #6870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
changed the title
dalg24
approved these changes
Mar 11, 2024
Rombur
approved these changes
Mar 12, 2024
|
Please add to the 4.3 changelog |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
KOKKOS_EXPORT_CMAKE_TPL(oneDPL)we are missing findingoneDPLin downstream code in caseoneDPLis not included in theoneAPIinstallation used for theSYCLbackend but is installed as CMake package elsewhere (which is uncommon). This pull request is fixing a bug in the exported configuration for this case.Also, move linking with
oneDPLtoalgorithms.Support for
oneDPLwas initially added in #5229 (Kokkos 4.1.00).