package-builder: add podman support via --container_tool #1722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the launcher to be built on Fedora, which ships with a working podman environment that runs as a regular user (no background daemon required). In comparison, setting up Docker is a pain and gives the user root-level privilege.
This PR does add the ":Z" flag to container volume mounts, so that the volume permissions allow access from the host filesystem, which the build process assumes. Without this flag, rootless podman encounters an error:
The ":z" mount flag also works, but has a looser security model. This flag is supported by Docker and Podman.
This PR also changes the container pull location from an ambiguous "kolide/fpm:latest" to the absolute path of ""docker.io/kolide/fpm:latest". This is necessary as Podman is not pre-programmed to pull from "docker.io" by default.