Add request duration to access logs #43
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Troncos in Salsa and now starting to build new dashboards in Grafana I think this feature would be nice to have.
We get Prometheus metrics on request duration, and we can look at traces/spans that are long. But with metrics we can't backtrack to find a specific slow request and with traces we're combined with Tienda-data so we can't filter at where Salsa was slow.
Adding this would allow us to make dashboards that would light up the slow queries and we could follow the traceID links to drill down into why.
Implementation wise the naming and way of doing this is inspired by two things, the gunicorn logging in Tienda and this asgi logger framework I found.
Open to doing it differently as I don't know the Troncos way of things, but figured I'd just do a quick PR to test it first.
At least it works on my machine 😄 :