Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core changes - refactor map related atoms architecture #118

Open
propakov opened this issue Aug 24, 2022 · 2 comments
Open

Core changes - refactor map related atoms architecture #118

propakov opened this issue Aug 24, 2022 · 2 comments

Comments

@propakov
Copy link
Contributor

We have atoms architecture implying that we can only have 1 map in the app.
But now, we have another map on /bivariate-manager, and will have another one.

We need to refactor our existing architecture solution to be sure that we can have several independent maps.
After refactoring we want to be sure that one map won't affect another.

General idea:

  • have a class/atom/etc that will unite particular currentMapAtom, layersRegistry, layerOrderManager and other related entities like mountedLayersAtom, hiddenLayersAtom and etc.
  • all atoms that depends on currentMapAtom should depend on this new unit, as now we gonna work with particular map.
@IlyaIzr
Copy link
Contributor

IlyaIzr commented Aug 24, 2022

Several maps per app sounds like heavy stuff for browser, I think we would also need to think about perfomance.

When another map turned on - will we remove map DOM element or remove all the layers and sources and mount new ones?

@Akiyamka
Copy link
Contributor

Akiyamka commented Aug 24, 2022

We can reuse map engine and canvas, but for app logic if should look like different maps with independed states

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants