Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve selectors for toolbar resizing to enhance test reliability #852

Open
coderabbitai bot opened this issue Oct 2, 2024 · 0 comments
Open

Improve selectors for toolbar resizing to enhance test reliability #852

coderabbitai bot opened this issue Oct 2, 2024 · 0 comments
Assignees
@amurKontur

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2024

As discussed in this comment, the selectors used in the toolbar resizing functionality may rely on the specific order and number of svg elements. This dependency can make tests brittle if the DOM structure changes. It's recommended to use data-testid attributes and getByTestId selectors for more stable and maintainable tests.

Referenced PR: #842

Requested by @amurKontur.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amurKontur amurKontur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amurKontur