Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also check width of arrow keys, backspace and del when enable internal wcwidth #44

Closed
xhebox opened this issue Feb 1, 2017 · 1 comment

Comments

@xhebox
Copy link

xhebox commented Feb 1, 2017

e.g. 😂 will remain the left part when typing backspace <-.

@kovidgoyal
Copy link
Owner

Internal wcwidth should only be used if the program you are running in the terminal is also using an up to date wcwidth. It is not the terminal's responsibility to make backspace, etc. work with wide characters, it is the client program that has to send the correct number of backspaces, cursor movement commands and so on.

You can test this by using some wide character known to your system wcwidth, then you will see that backspace, etc work correctly in shells, vim, etc.

If the terminal started changing how backspace, cursor movement, etc command worked based on the wcwidth implementation, then it would break for all characters in which the system wcwidth and the internal wcwidth agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants