Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcc: link with dynamic libbpf #441

Merged
merged 1 commit into from
Mar 11, 2021
Merged

bcc: link with dynamic libbpf #441

merged 1 commit into from
Mar 11, 2021

Conversation

teknoraver
Copy link
Contributor

@teknoraver teknoraver commented Mar 10, 2021

Link bcc dynamically against libbpf. This reduces the size of libbcc.so
from 68 MB to 3 MB.
Backport some patches from upstream which are needed for the actual
dynamic linking.

Depends on openembedded/meta-openembedded#320

Signed-off-by: Matteo Croce [email protected]


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Link bcc dynamically against libbpf. This reduces the size of libbcc.so
from 68 MB to 3 MB.
Backport some patches from upstream which are needed for the actual
dynamic linking.

Signed-off-by: Matteo Croce <[email protected]>
@teknoraver teknoraver requested a review from kraj as a code owner March 10, 2021 16:12
@kraj
Copy link
Owner

kraj commented Mar 11, 2021

I am seeing build failures on aarch64/musl see http://sprunge.us/nAGWNa

@teknoraver
Copy link
Contributor Author

Yes, this is expected as the PR depends on openembedded/meta-openembedded#320

Can you try both?

@kraj
Copy link
Owner

kraj commented Mar 11, 2021

it is using both

@teknoraver
Copy link
Contributor Author

OK, so it should be specific to musl. I tried only x86_64/libc and aarch64/libc6.

If all the other configurations work, we can exclude musl or stick with static linking

@kraj
Copy link
Owner

kraj commented Mar 11, 2021

I think the issue I was facing was different, where a dependency was missing I have sent a patch for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants