Possibility to specify type attribute #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it will be possible to specify or type attribute of <style>
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 80.95% 81.25% +0.29%
==========================================
Files 4 4
Lines 63 64 +1
Branches 15 17 +2
==========================================
+ Hits 51 52 +1
Misses 11 11
Partials 1 1
Continue to review full report at Codecov.
|
|
Why not just remove this line at all? isomorphic-style-loader/src/insertCss.js Line 69 in a990d94 |
|
For backward compatibility at least |
|
@frenzzy Any news on this PR? |
|
@BilyachenkoOY sorry, I am not interested in maintenance |
|
@koistya can you help with this? :) |
dazlious
requested changes
Aug 9, 2021
Comment on lines
+69
to
+70
| if (type === undefined || typeof type === 'string') | ||
| elem.setAttribute('type', type || 'text/css') |
There was a problem hiding this comment.
Suggested change
| if (type === undefined || typeof type === 'string') | |
| elem.setAttribute('type', type || 'text/css') | |
| if (!type || typeof type === 'string') { | |
| elem.setAttribute('type', type || 'text/css') | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it will be possible to specify type attribute of <style>.
This will allow to fix warning from W3C validator "The type attribute for the style element is not needed and should be omitted.".