-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout step fails on Windows with error "Failed to find a parent section match for a page" #58
Comments
After #59 these are the remaining failures:
I was able to work around this by replacing this code with the following lines, but it's obviously just a hack and should be properly fixed by someone who better understand the codebase (and Zig, this is my first time actually using the language) var ref_native = try gpa.dupe(u8, ref);
if (builtin.os.tag == .windows) {
std.mem.replaceScalar(u8, ref_native[0..], '/', std.fs.path.sep);
}
const res = try page_finder.find(.{
.ref = .{
.site = page_site,
.path = ref_native,
},
}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Zig's website builds fail on Windows with error
"Failed to find a parent section match for a page"
because some path separators are hardcoded to/
, and cached paths are saved with the native separator resulting in failing equality checks with paths using the/
separator.Notice how the path separator in
md_rel_path
differs from the ones in the section file contents.Hacking around I was able to confirm that fixing this issue allows to complete a
ziglang.org
build on Windows.The text was updated successfully, but these errors were encountered: