Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery settings pop up every time the app starts. #1252

Closed
1 of 2 tasks
ChromiaCat opened this issue Feb 22, 2024 · 7 comments
Closed
1 of 2 tasks

Battery settings pop up every time the app starts. #1252

ChromiaCat opened this issue Feb 22, 2024 · 7 comments
Labels
wontfix / Alternatively patched This will not be worked on or it's already patched using an alternative method

Comments

@ChromiaCat
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

It might not be a bug but more of an annoyance with the app.

If I've set the battery saver settings for the app on anything other than No Restrictions (MIUI) it keeps bringing up the settings to change it and it kinda annoys me, it should be just a fresh install kinda thing and after that it should stop pestering the user.

Expected Behavior

It only brings up the battery saver settings for Spotube only the first time after install and never again.

Steps to reproduce

  1. Install Spotube.
  2. Set the battery saver settings for it on anything but No Restrictions.
  3. Start the app however many times you want.
  4. Profit.

Operating System

Android 11

Spotube version

v3.4.1

Installation source

Play Store (Android)

Additional information

No response

Self grab

  • I'm ready to work on this issue!
@ChromiaCat ChromiaCat added the bug Something isn't working label Feb 22, 2024
@KRTirtho
Copy link
Owner

KRTirtho commented Feb 24, 2024

This is because custom OEM android ROMs kills Spotube from background automatically without user's concern
Learn More

So, to have a better experience and for letting users know that the OEM is the one to be blamed for this kind of artificial battery health and poor battery saving tactics, this banner is shown, so the user can whitelist Spotube from the ROM's "battery saver"

This is unfortunately an intended behaviour to allow Spotube to play in the background without getting interrupted

@KRTirtho KRTirtho added wontfix / Alternatively patched This will not be worked on or it's already patched using an alternative method and removed bug Something isn't working labels Feb 24, 2024
@ChromiaCat
Copy link
Author

I realize that but from my experience Spotube doesn't get stopped, at least for me. Would it be too much trouble to add a toggle to stop that?

@KRTirtho
Copy link
Owner

KRTirtho commented Mar 5, 2024

By default, users will be asked once after install or unless neither Allow/Deny was pressed. So I suppose there's something that went wrong. Did you try to clear data?

@ChromiaCat
Copy link
Author

By default, users will be asked once after install or unless neither Allow/Deny was pressed. So I suppose there's something that went wrong. Did you try to clear data?

Just did and it still asks every time I open it.

@KRTirtho
Copy link
Owner

KRTirtho commented Mar 7, 2024

I tried with 5 different device OEM OS including RealmeUI, OxygenOS, Pixel, MIUI, OneUI and none of them had this issue.
I'm not sure if your particular device is having this issue or the version of MIUI

@ChromiaCat
Copy link
Author

I don't think it's an issue with my device, if I set Spotube to no background restrictions it stops bothering me.

Is it possible to make that a notification in the app with an option to not ask again?

@ChromiaCat
Copy link
Author

Thanks for fixing it, you rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix / Alternatively patched This will not be worked on or it's already patched using an alternative method
Projects
None yet
Development

No branches or pull requests

2 participants