Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exclusion logic from click event to function #75

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

brazilianldsjaguar
Copy link

I was working with Twitter Bootstrap 3, particularly with their tabbing features. Unfortunately, the only way to 'exclude' anything is to do so on the $.fn.smoothScroll, which the site I was working with didn't use -- they rolled their own click-event handler to call the $.smoothScroll function. Thus, there was no way for me tell the plugin that I didn't want it to smooth scroll to tab contents, even with the $.smoothScroll('options', obj) overrides.

The change, then, moves that exclusion logic (almost as-is) from the click even handler to the smoothScroll function. That way, whether you indicate it in the $.fn.smoothScroll or come in later and apply it to optionOverrides, your exclusion will be honored.

(Note: This is my first "major" pull request, not sure if I did it right or built it right, etc, please forgive any shortcomings (and I'm of course open to your feedback!))

brazilianldsjaguar and others added 4 commits March 2, 2015 08:35
Update to latest version
 smoothScroll function. This allows opt-in exclusion when necessary.
 smoothScroll function. This allows opt-in exclusion when necessary.
@brazilianldsjaguar
Copy link
Author

To be clear, this allows the flexibility for a developer to exclude items from smooth scrolling, even if the library is 'forced' upon them via other means (or otherwise do not have control of the implementation of the library).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant