KTOR-7490 Improved source file definitions #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhham
force-pushed
the
bjhham/multiplatform-support
branch
from
af6b5cf
to
04e5f32
Compare
e5l
approved these changes
Oct 4, 2024
| @@ -9,4 +9,5 @@ prerequisites: | |||
| installation: | |||
| default: install.kt | |||
| outside_app: outside_app.kt | |||
| source_file_kt: CitySchema.kt | |||
| sources: | |||
| - file: CitySchema.kt | |||
There was a problem hiding this comment.
We also can support mustache templates in the future to make generated files customizable
osipxd
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tackles this issue:
It was noticed by @Mr3zee when attempting to introduce the kRPC plugin. With this change, you can now add multiple source files to the plugin's sample code, and also target which module you'd like it in when using multi-platform support (i.e., "common"), which should make a little more sense in the next PR for the back end.