-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Fix the tricky import changes in Python SDK #2416
Labels
Comments
/remove-label lifecycle/needs-triage |
@kubeflow/wg-automl-leads Protocol Buffers code generator is extensible. So, TBH, I'm wondering if we can implement custom Python protoc plugin for Katib since it seems that protocolbuffers/protobuf#7061 was opened 4 years ago, and then the issue is not still resolved... |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What you would like to be added?
This issue is created to track the tricky import changes in Python SDK.
Currently, we have no choice but to do the tricky import changes because: #2398 (comment) .
katib/Makefile
Lines 169 to 179 in a524f33
katib/sdk/python/v1beta1/setup.py
Lines 41 to 54 in a524f33
Why is this needed?
As I described in #2398 (comment) , we need to discard the tricky import changes when protocolbuffers/protobuf#7061 supports options like
python_package
to mutate the importing package name.Love this feature?
Give it a 👍 We prioritize the features with most 👍
The text was updated successfully, but these errors were encountered: