-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Add Some Checks for metrics
Field in report_metrics()
Interface
#2421
Comments
/remove-label lifecycle/needs-triage |
@andreyvelich: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'd like to work on this since this is related to my GSoC project: #2340 /assign |
After investigating this issue, I find that:
katib/pkg/db/v1beta1/mysql/mysql.go Lines 134 to 135 in bc09cfd
|
What you would like to be added?
We decide to add some conditional checks in
report_metrics()
to ensure it works as expected when encounting some tricky corner case and enhance its robustness.Why is this needed?
In the AutoML and Training WG Community Call, @tenzen-y asked what would happen if we pushed the same metrics twice in a single container. However, the current version of the
report_metrics()
API does not process this corner case.Thus, we decided to raise an issue discussing the possible corner case that
report_metrics()
might meet with. Everyone is welcome to put your valuable insights and suggestions here!Love this feature?
Give it a 👍 We prioritize the features with most 👍
The text was updated successfully, but these errors were encountered: