Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #651: Update kfserving manifests to 0.2.1 #875: Cluster local gateway Istio Gateway manifests This is #876: Cluster local gateway for Istio 1.1.6 Cherry pick of #651 #875 #876 on v1.0-branch. #651: Update kfserving manifests to 0.2.1 #875: Cluster local gateway Istio Gateway manifests This is #876: Cluster local gateway for Istio 1.1.6 #886

Conversation

animeshsingh
Copy link
Contributor

@animeshsingh animeshsingh commented Feb 10, 2020

This change is Reviewable

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@yuzisun
Copy link
Member

yuzisun commented Feb 10, 2020

/lgtm

@krishnadurai
Copy link
Contributor

/assign

@krishnadurai
Copy link
Contributor

krishnadurai commented Feb 10, 2020

@animeshsingh @Tomcli While I test Istio 1.3.1 with kfctl_istio_dex.yaml, Knative 0.11.1, and KFServing 0.2.1 on GKE 1.14.10; I come across this issue: knative/serving#6793

Otherwise LGTM.

@krishnadurai
Copy link
Contributor

krishnadurai commented Feb 10, 2020

Referring to the issue kserve/kserve#668 : A method to whitelist the URIs of deployed inference services will solve the above issue.

Copy link
Contributor

@krishnadurai krishnadurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@krishnadurai
Copy link
Contributor

krishnadurai commented Feb 11, 2020

@googlebot I consent.

1 similar comment
@yuzisun
Copy link
Member

yuzisun commented Feb 11, 2020

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@animeshsingh
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants