Introduce ManagedBy field in RunPolicy #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszadkow
force-pushed
the
feature/introduce-managedby
branch
3 times, most recently
from
9d9f891
to
4e57d1a
Compare
|
/ok-to-test |
mszadkow
force-pushed
the
feature/introduce-managedby
branch
2 times, most recently
from
971770b
to
08d9e2f
Compare
Signed-off-by: Michal Szadkowski <[email protected]>
Signed-off-by: Michal Szadkowski <[email protected]>
Signed-off-by: Michal Szadkowski <[email protected]>
mszadkow
force-pushed
the
feature/introduce-managedby
branch
from
08d9e2f
to
00e84e1
Compare
Signed-off-by: Michal Szadkowski <[email protected]>
Signed-off-by: Michal Szadkowski <[email protected]>
Signed-off-by: Michal Szadkowski <[email protected]>
mszadkow
force-pushed
the
feature/introduce-managedby
branch
from
00e84e1
to
0e35914
Compare
tenzen-y
reviewed
Sep 24, 2024
mszadkow
force-pushed
the
feature/introduce-managedby
branch
2 times, most recently
from
2381586
to
bc37bfd
Compare
|
@tenzen-y anything else to add? |
Signed-off-by: Michal Szadkowski <[email protected]>
mszadkow
force-pushed
the
feature/introduce-managedby
branch
from
bc37bfd
to
4ac4cb2
Compare
tenzen-y
reviewed
Oct 1, 2024
Signed-off-by: Michal Szadkowski <[email protected]>
mszadkow
force-pushed
the
feature/introduce-managedby
branch
from
c199396
to
08a3ac8
Compare
mimowo
reviewed
Oct 3, 2024
Signed-off-by: Michal Szadkowski <[email protected]>
mszadkow
force-pushed
the
feature/introduce-managedby
branch
from
26d3283
to
e1eae61
Compare
mimowo
reviewed
Oct 7, 2024
Replace backoff and consistently with sleep Signed-off-by: Michal Szadkowski <[email protected]>
mimowo
reviewed
Oct 8, 2024
…ait constants Signed-off-by: Michal Szadkowski <[email protected]>
mszadkow
force-pushed
the
feature/introduce-managedby
branch
from
983e2da
to
f91b8d2
Compare
tenzen-y
reviewed
Oct 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Oct 10, 2024
| @@ -131,6 +139,17 @@ type RunPolicy struct { | |||
| // Defaults to false. | |||
| // +kubebuilder:default:=false | |||
| Suspend *bool `json:"suspend,omitempty"` | |||
|
|
|||
| // ManagedBy is used to indicate the controller or entity that manages a MPIJob. | |||
| // The value must be either an empty, 'kubeflow.org/mpi-operator' or | |||
There was a problem hiding this comment.
Suggested change
| // The value must be either an empty, 'kubeflow.org/mpi-operator' or | |
| // The value must be either empty, 'kubeflow.org/mpi-operator' or |
There was a problem hiding this comment.
@mszadkow Could you address this comment in a separate PR?
There was a problem hiding this comment.
Sure, will be addressed asap
|
@alculquicondor @tenzen-y |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ManagedBy to be able delegate reconciliation process to external controller.
Fixes #646