Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Kubeflow Pipelines 1.2 umbrella tracker #4565

Closed
1 task done
Bobgy opened this issue Sep 29, 2020 · 17 comments
Closed
1 task done

[Release] Kubeflow Pipelines 1.2 umbrella tracker #4565

Bobgy opened this issue Sep 29, 2020 · 17 comments

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Sep 29, 2020

/assign @Bobgy @Ark-kun
This should temporarily resolve issues like #4409.

TODOs:

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 29, 2020

We should probably finish #4540 first

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 13, 2020

Because we haven't been able to release a minor version for a while, this is our next priority

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 20, 2020

/cc @Ark-kun
The top blocker is fixing master branch postsubmit tests.

@Bobgy Bobgy removed their assignment Oct 20, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 22, 2020

The most important next step can be releasing a 1.1.0-alpha.1 to allow dogfooding.

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 2, 2020

I'm going to release a 1.1.0-alpha.1 for preview, some non-core sample tests are failing in postsubmit including container builder. I'll ignore them for this release.

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 2, 2020

Auto generated changelog has a problem:
https:/kubeflow/pipelines/blob/7d36f48482d93f331664a851842276b733f1686a/CHANGELOG.md#110-alpha1-2020-11-02

It shows all changes from 0.5.1 to 1.1.0-alpha.1, because 1.0.0 was released on release-1.0 branch.

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 2, 2020

1.1.0-alpha.1 is released, feedback welcomed if there are any problems: https:/kubeflow/pipelines/releases/tag/1.1.0-alpha.1

@Bobgy Bobgy changed the title [Release] Kubeflow Pipelines 1.1.0 umbrella tracker [Release] Kubeflow Pipelines 1.1 umbrella tracker Dec 2, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 2, 2020

/cc @rui5i
We need to upgrade MLMD to 0.25.1

Reference: google/ml-metadata#74 (comment)

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 2, 2020

And we need to wait for a resolution of #4847

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 4, 2020

@rui5i Handling #4855 properly is still tricky.
I'll write about what we need to do here.

/cc @chensun

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 4, 2020

EDIT: ignore the below, kfp SDK release is now separate, so releasing other stuff doesn't need to be blocked on it.

  1. Merge chore(sdk): bump sdk's dependency on kfp-server-api #4855 (I've updated dependency to 'kfp-server-api>=1.1.1b1, <2.0.0', so the pre-released kfp-server-api 1.1.1b1 can be properly installed via pip)
  2. Release 1.1.2-rc.1 as usual
  3. During 1.1.2 release
    1. Run ./hack/release-imp.sh instead of ./hack/release.sh during release, the imp script add all changes to the local repo, so it's still possible editing the release commit before pushing it.
    2. Release kfp-server-api 1.1.2 in pypi directly from the local folder
    3. Update
      'kfp-server-api>=0.2.5, <2.0.0',
      to >=1.1.2
    4. Commit the release commit and push to master
    5. Continue normal release process

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 4, 2020

/cc @chensun @Ark-kun
what do you think about above process for releasing change #4855?

Maybe, going forward, we should always release kfp-server-api package first in the release process, so kfp package can update its dependencies during release.

@chensun
Copy link
Member

chensun commented Dec 4, 2020

  1. Merge chore(sdk): bump sdk's dependency on kfp-server-api #4855 (I've updated dependency to 'kfp-server-api>=1.1.1b1, <2.0.0'

The offending PR only exists in master, thus not available in 1.1.1b1, right? In that case, isn't 1.1.1b1 the same as 0.2.5?
If that's the case, then we can release 1.1.2-rc1 as usual without waiting for #4855, given we're not releasing kfp package 1.1.2-rc1. Instead, we are releasing kfp 1.1.2 from master. And only this step is blocked by the setup.py change with kfp-server-api>=1.1.2-rc1 (or >1.1.1).

Maybe, going forward, we should always release kfp-server-api package first in the release process, so kfp package can update its dependencies during release.

Agree.

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 4, 2020

@chensun the offending PR was released in 1.1.1b1 already, but yes, you are right this only blocks kfp release, we can skip this problem for backend release.

@chensun
Copy link
Member

chensun commented Dec 4, 2020

@chensun the offending PR was released in 1.1.1b1 already, but yes, you are right this only blocks kfp release, we can skip this problem for backend release.

I see. Then we can merge #4855 as-is.

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 17, 2020

Release blocker: #4903

@Bobgy Bobgy changed the title [Release] Kubeflow Pipelines 1.1 umbrella tracker [Release] Kubeflow Pipelines 1.2 umbrella tracker Jan 18, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 18, 2021

All done

@Bobgy Bobgy closed this as completed Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants